-Added GitHub issue template for bug reports. [Firehawke, Vas Crabb]

-sega: Got rid of some unnecessary and contradictory member
 initialisations.  Having members initialised in the constructor and
 also at declarations just leads to confusion.
This commit is contained in:
Vas Crabb 2023-01-07 03:52:51 +11:00
parent 2892a11538
commit f6f47adbdb
4 changed files with 115 additions and 10 deletions

91
.github/ISSUE_TEMPLATE/bug-report.yml vendored Normal file
View File

@ -0,0 +1,91 @@
name: "Bug report"
description: Report incorrect or unexpected behaviour.
body:
- type: markdown
attributes:
value: |
## Important: Read First
Issues are not to be used for support requests or discussion. They are only to be used for reporting reproducible issues.
Before reporting an issue:
* Please ensure you have read the [guidelines for contributors](https://docs.mamedev.org/contributing/).
* We only accept bug reports against the latest version of MAME. Older versions are not supported.
* Only official versions of MAME are supported. Derivative versions (e.g. MAMEUI, NegaMAME or RetroArch cores) are not supported.
* User-facing bugs in released versions of MAME should generally be reported at [MAME Testers](https://mametesters.org/).
* Please search for existing [issues on GitHub](https://github.com/mamedev/mame/issues) and [bug reports at MAME Testers](https://mametesters.org/view_all_bug_page.php) before opening a new issue!
- type: input
attributes:
label: MAME version
description: |
You can obtain the version from MAME itself, either by running `mame -version` at the command line or from the main menu. Include the git commit hash if not a tagged release.
placeholder: "0.xxx (mame0xxx-nn-gxxxxxxxxxxx)"
validations:
required: true
- type: textarea
attributes:
label: System information
description: Provide environment details, including your operating system, CPU architecture, system locale and display language, if applicable. For video output bugs, include your video hardware (GPU), driver version, and the MAME video output module youre using (e.g. opengl or bgfx). For input handling bugs, include the input peripherals and MAME input modules youre using.
placeholder: |
Windows 11, 64-bit, version 22H2, USA, US English
x86-64, 32GB system RAM, GeForce RTX 4090 driver version 516.54
Using a Hori RAP4 Kai arcade stick in XInput mode connected via USB
bgfx video output (vulkan backend), winhybrid joystick module
validations:
required: true
- type: textarea
attributes:
label: INI configuration details
description: Copy your mame.ini here.
placeholder: |
#
# CORE CONFIGURATION OPTIONS
#
readconfig 1
writeconfig 0
render: INI
- type: input
attributes:
label: Emulated system/software
description: |
The exact emulated system and software affected. Please include short names for systems and software list items. Include version and media type. May not be applicable for issues with parts of MAMEs UI, like the system selection menu.
placeholder: PC Engine (pce), CD-ROM² Super System Card (v3.0) (pce:scdsys), Forgotten Worlds (Japan) (pcecd:forgottnj)
- type: textarea
attributes:
label: Incorrect behaviour
description: |
A concise description of the undesirable behaviour you're experiencing. Be specific just saying it “doesnt work” isnt enough detail.
validations:
required: true
- type: textarea
attributes:
label: Expected behaviour
description: |
A concise description of what you expect should happen. For emulation issues, include an original reference for the correct behaviour if possible. If you have access to the original hardware for the emulated system, it helps to make a recording of the correct behaviour for comparison.
validations:
required: true
- type: textarea
attributes:
label: Steps to reproduce
description: |
Steps to reproduce the issue. Assume the person reading is familiar with MAME itself, but not necessarily familiar with the emulated system and software in question. For emulation issues, input recordings and/or saved state files for reproducing the issue can be invaluable.
placeholder: |
1. I started MAME with the following command line (where applicable):
2. I did the following steps..
3.
4. I received this error or undesired result.
- type: textarea
attributes:
label: Additional details
description: |
Any additional relevant details. Include things like the selected BIOS version, and emulated peripheral (slot device) configuration.
placeholder: |
SuperMac Spectrum/8 Series III card with firmware version 1.2 in NuBus slot 9.

14
.github/ISSUE_TEMPLATE/config.yml vendored Normal file
View File

@ -0,0 +1,14 @@
blank_issues_enabled: true
contact_links:
- name: MAME Testers
url: https://mametesters.org/
about: For reporting user-facing bugs in released versions of MAME.
- name: MAMEdev Discussions on GitHub
url: https://github.com/orgs/mamedev/discussions
about: For questions and discussion.
- name: MAMEdev Forum
url: https://forum.mamedev.org/
about: Official MAMEdev forums.
- name: r/MAME
url: https://www.reddit.com/r/MAME/
about: Community forum for discussion and support.

View File

@ -65,8 +65,8 @@ private:
devcb_write_line::array<3> m_out_cnt_cb;
uint8_t m_output_latch[8];
uint8_t m_cnt = 0;
uint8_t m_dir = 0;
uint8_t m_cnt;
uint8_t m_dir;
uint8_t m_dir_override;
};

View File

@ -51,8 +51,8 @@ public:
, m_romboard(ROM_BOARD_INVALID)
, m_custom_io_r(*this)
, m_custom_io_w(*this)
, m_grayscale_enable(false)
, m_vdp_enable(false)
, m_grayscale_enable(0)
, m_vdp_enable(0)
, m_vdp_mixing(0)
, m_lghost_value(0)
, m_lghost_select(0)
@ -170,15 +170,15 @@ private:
write16sm_delegate m_custom_io_w;
// internal state
emu_timer * m_init_boost_timer = nullptr;
int m_grayscale_enable = 0;
int m_vdp_enable = 0;
uint8_t m_vdp_mixing = 0;
emu_timer * m_init_boost_timer;
int m_grayscale_enable;
int m_vdp_enable;
uint8_t m_vdp_mixing;
bitmap_ind16 m_temp_bitmap;
// game-specific state
uint8_t m_lghost_value = 0;
uint8_t m_lghost_select = 0;
uint8_t m_lghost_value;
uint8_t m_lghost_select;
};
#endif // MAME_INCLUDES_SEGAS18_H